v7labs / darwin-py

Library and commandline tool for managing datasets on darwin.v7labs.com
MIT License
115 stars 42 forks source link

[DAR-1679][External] Made darwin-py ignore the .v7/metadata.json properties manifest when reading JSON annotation files #823

Closed JBWilkie closed 4 months ago

JBWilkie commented 4 months ago

Problem

In a previous bug fix (DAR-1609) it was discovered that pulling a dataset release does not include the properties metadata file if one needs to be downloaded. This was fixed in that ticket. However, there are several functions in darwin-py that assume every JSON file in the annotations directory is annotation file. If there's a properties metadata file, this is no longer true, and this causes issues

Solution

Changelog

Made darwin-py ignore the .v7/metadata.json properties manifest when reading JSON annotation files

linear[bot] commented 4 months ago

DAR-1679 BUG: The presence of the .v7/metadata.json file breaks a few functions in darwin-py

JBWilkie commented 4 months ago

Since we're doing the same glob() statement repeatedly with logic to avoid /.v7/ in filepaths, I can abstract this into a function and then add a unit test if it's deemed worthwhile