v7labs / darwin-py

Library and commandline tool for managing datasets on darwin.v7labs.com
MIT License
115 stars 42 forks source link

[StepSecurity] Apply security best practices #905

Closed step-security-bot closed 2 months ago

step-security-bot commented 2 months ago

Summary

This pull request is created by StepSecurity at the request of @JBWilkie. Please merge the Pull Request to incorporate the requested changes. Please tag @JBWilkie on your message if you have any questions related to the PR.

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Harden-Runner is an open-source security agent for the GitHub-hosted runner to prevent software supply chain attacks. It prevents exfiltration of credentials, detects tampering of source code during build, and enables running jobs without sudo access.

Harden runner usage You can find link to view insights and policy recommendation in the build log Please refer to [documentation](https://docs.stepsecurity.io/harden-runner/how-tos/enable-runtime-security) to find more details.

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Static Code Analysis (also known as Source Code Analysis) is usually performed as part of a Code Review (also known as clear-box testing) and is carried out at the Implementation phase of a Security Development Lifecycle (SDL). Static Code Analysis commonly refers to the running of Static Code Analysis tools that attempt to highlight possible vulnerabilities within โ€˜staticโ€™ (non-running) source code by using techniques such as Taint Analysis and Data Flow Analysis.

Pin image tags to digests in Dockerfiles. With the Docker v2 API release, it became possible to use digests in place of tags when pulling images or to use them in FROM lines in Dockerfiles.

The Dependency Review Workflow enforces dependency reviews on your pull requests. The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests, and warns you about the associated security vulnerabilities. This gives you better visibility of what's changing in a pull request, and helps prevent vulnerabilities being added to your repository.

OpenSSF Scorecard is an automated tool that assesses a number of important heuristics ("checks") associated with software security and assigns each check a score of 0-10. You can use these scores to understand specific areas to improve in order to strengthen the security posture of your project.

Scorecard workflow also allows maintainers to display a Scorecard badge on their repository to show off their hard work.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

wiz-inc-4ad3b29aa7[bot] commented 2 months ago

Wiz Scan Summary

IaC Misconfigurations 0C 1H 0M 1L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 0M 1L 0I
Secrets 0๐Ÿ”‘
saurbhc commented 2 months ago

Amazing! I really like the idea of pinning github action versions to specific hashes!

Q) Can dependabot work with hashes rather than versions? and upgrade the hashes when there's an action update? ๐Ÿค”

JBWilkie commented 2 months ago

Amazing! I really like the idea of pinning github action versions to specific hashes!

Q) Can dependabot work with hashes rather than versions? and upgrade the hashes when there's an action update? ๐Ÿค”

If I've understood this correctly (here's an example), then yes it should work. Someone even merged a PR to update the commented version numbers themselves