v8 / node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:
https://nodejs.org
Other
171 stars 66 forks source link

Don't use soon-to-be-deprecated V8 Api #179

Closed isheludko closed 6 months ago

isheludko commented 6 months ago

V8 announced deprecation of the following methods:

See https://crrev.com/c/5006387.

This CL slightly changes behavior of the following properties:

The difference is that they will now behave like a regular writable JavaScript data properties - in case setter callback is not provided they will be be reconfigured from a native data property (the one that calls C++ callbacks upon get/set operations) to a real data property (so subsequent reads will no longer trigger C++ getter callbacks).

victorgomes commented 6 months ago

LGTM!