v8 / node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:
https://nodejs.org
Other
171 stars 66 forks source link

Add node_enable_deprecated_declarations_warnings GN flag #181

Closed isheludko closed 6 months ago

isheludko commented 6 months ago

Warnings about using deprecated declarations were disabled by default which made it impossible to ensure that Node doesn't use V8's deprecated Apis - V8's node-ci bots just didn't complain.

The flag allows enabling deprecated warnings and suppresses known issue with using deprecated functionality in c-ares (see https://github.com/nodejs/node/issues/52464).

The flag is off by default which preserves the existing behavior.

Drive-by: fix deps/openssl/unofficial.gni by exposing the required OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs similarly to how it's done in gyp configs.

pthier commented 6 months ago

LGTM, thanks!