v8 / node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:
https://nodejs.org
Other
171 stars 66 forks source link

Make test-http-server-keepalive-req-gc robust to GC heuristics #186

Closed eti-p-doray closed 5 months ago

eti-p-doray commented 5 months ago

This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object.