search

v8 / v8.dev

The source code of v8.dev, the official website of the V8 project.
https://v8.dev/
Apache License 2.0
954 stars 320 forks source link

Merge legacy.js and main.mjs into main.js #755

Closed camillobruni closed 6 months ago

camillobruni commented 6 months ago

There is no advantage of using modules over classic scripts if there are no imports. We currently have the legacy script as a nomodule fallback, we can merge them easily into a single main.js script and simplify the page a bit.

tomayac commented 6 months ago

@camillobruni I didn't look closely, but it seems like this potentially broke dark mode. Could you have a look, please?

camillobruni commented 6 months ago

Ups right, I accidentally removed the dark-mode import... planned to replace this with some simpler logic. Will fix this tomorow.

tomayac commented 6 months ago

Filed https://github.com/v8/v8.dev/issues/758 as a reminder. Thanks for working on this!