v8hid / infinite-zoom-automatic1111-webui

infinite zoom effect extension for AUTOMATIC1111's webui - stable diffusion
MIT License
658 stars 62 forks source link

Upscaling acceleration #94

Open vsemecky opened 1 year ago

vsemecky commented 1 year ago

When I tried InfiniteZoom together with upscaling, I found that it upscales every each frame of the video, which is unnecessary in this case. It would be enough to upscale only the main generated frames and do the zooming on the upscaled ones. That would save a lot of time.

The implementation seemed simple to me, so I wanted to take it on and code this feature directly. However, I found out that there is already the optimize_upscale branch by @GeorgLegato that does exactly this.

I want to ask, what does the future look like with this feature? If that branch isn't in the development, I'd be happy to take it on, I just find the modifications unnecessarily complicated. My idea is more simple: 1) after generating the images, upscale all of them. 2) skip/disable upscaling everywhere else

GeorgLegato commented 1 year ago

check please the branch overmask_... beside to smarter upscaling it needs to write upscale/interpolated frames as a stream to video. older approach is to keep al in ram which is insane for 2 mins/60fps/4k

in the overmask_ branch use the "corner" outpainting strategy, the Center one is not frame corrected but could still work

Corners will extend the target size by your given outpainting width, then zoom in.

NeoPrint3D commented 1 year ago

Please add upscaling improvements