search

v923z / micropython-ulab

a numpy-like fast vector module for micropython, circuitpython, and their derivatives
https://micropython-ulab.readthedocs.io/en/latest
MIT License
422 stars 116 forks source link

Fix error message for maximum number of dimensions #532

Closed dpgeorge closed 2 years ago

dpgeorge commented 2 years ago

Prior to this change, if you built ulab with the default 2 dimensions and ran code that needed more than 2 (eg tests/4d/complex/imag_real.py) it would error out with the confusing message "ValueError: maximum number of dimensions is 4".

v923z commented 2 years ago

Prior to this change, if you built ulab with the default 2 dimensions and ran code that needed more than 2 (eg tests/4d/complex/imag_real.py) it would error out with the confusing message "ValueError: maximum number of dimensions is 4".

Indeed. Many thanks!

v923z commented 2 years ago

Again, thanks for your contribution, comments, and insights!

dpgeorge commented 2 years ago

Thanks for merging!