v923z / micropython-ulab

a numpy-like fast vector module for micropython, circuitpython, and their derivatives
https://micropython-ulab.readthedocs.io/en/latest
MIT License
432 stars 117 forks source link

fix: remove make axtls, added make submodules #542

Closed tejalbarnwal closed 2 years ago

tejalbarnwal commented 2 years ago

There has been an update with the new build instructions for micropython as found here

v923z commented 2 years ago

Thanks for the comments! I remove axtls from the build script. https://github.com/v923z/micropython-ulab/pull/540 passes with micropython. We are working on the circuitpython CI, but that is a different issue: https://github.com/v923z/micropython-ulab/issues/541

v923z commented 2 years ago

What I wanted to say is that the other PR should actually contain the fix for this.

tejalbarnwal commented 2 years ago

Just to confirm, I ran build.sh while commenting the line to run the test scripts. I am referring to the below code line

bash test-common.sh "${dims}" "micropython/ports/unix/micropython-$dims"

The above line interrupts the build process because gc.py fails the test case. image

The gc.py.exp is as follows

988.0000000000001
array([1.0, 1.0, 1.0, ..., 1.0, 1.0, 1.0], dtype=float64)
988.0000000000001
array([1.0, 1.0, 1.0, ..., 1.0, 1.0, 1.0], dtype=float64)

gc.py.out gives the following:

988.0
array([1.0, 1.0, 1.0, ..., 1.0, 1.0, 1.0], dtype=float64)
988.0
array([1.0, 1.0, 1.0, ..., 1.0, 1.0, 1.0], dtype=float64)

Am not sure why does it fails the test

v923z commented 2 years ago

The issue you mention is caused by the most recent commit in micropython https://github.com/micropython/micropython/commit/f9cbe6bc47dd4f5b8e85178caecd6f0de22b4c34, but I fixed this in https://github.com/v923z/micropython-ulab/pull/540/commits/c193e7f73b6720c770414235596c717345ca29f2 and thereafter. If you fetch the changes from the nonzero branch, you should be able to compile for micropython without errors.

v923z commented 2 years ago

Again, the CI produces no errors on micropython: https://github.com/v923z/micropython-ulab/runs/7528073593?check_suite_focus=true

tejalbarnwal commented 2 years ago

Right! Thank you

v923z commented 2 years ago

I think this PR is no longer needed.