Closed Gadgetoid closed 4 months ago
I believe this change can be made safely ahead of MicroPython merging that PR
Yes, definitely. Good idea @Gadgetoid !
Many thanks for keeping an eye on this!
Note: This needs a new compatibility release, since MicroPython have now shipped v1.23.0 with the STATIC macro removed - https://github.com/micropython/micropython/releases/tag/v1.23.0
@Gadgetoid I think I'm a bit confused now: the PR addressed the issue of the static keyword ahead of time, so we should be in sync with 1.23, shouldn't we? Or do you just simply want to create a release to indicate this fact?
Or do you just simply want to create a release to indicate this fact?
This! I think it's worth tagging a release though as you point out it's not at all required.
In hindsight I think I've just been submoduling and building against arbitrary points in the master branch anyway 😬
I think you bring up a valid point. So, here you go: https://github.com/v923z/micropython-ulab/releases.
Thank you!
Trying to get ahead of the changes proposed in micropython/micropython#13763.
I believe this change can be made safely ahead of MicroPython merging that PR, since
STATIC
should always resolve tostatic
in production.Methodology:
find -name *.c | xargs sed -Ei "s/(^| )STATIC($| )/\1static\2/"
to automate replacement in .c filesgrep -r STATIC
and manual fixes to the docs