Open kwagyeman opened 2 months ago
append should be relatively straightforward, and others might also find it useful, so I would be happy to add it.
Reading the documentation of vstack, it seems to me that it's only a shortcut to what you can already do: concatenate has already been implemented. If that doesn't match your requirements, we could discuss the addition of vstack
.
Also if this limitation could be removed.
Do you mean the fact that Boolean indices are supposed to be 1D arrays, or something else?
Reading the documentation of vstack, it seems to me that it's only a shortcut to what you can already do: concatenate has already been implemented. If that doesn't match your requirements, we could discuss the addition of vstack.
It's more about making it easier to use desktop code directly without having to modify it too much. vstack would just be a wrapper around concatenate.
Do you mean the fact that Boolean indices are supposed to be 1D arrays, or something else?
If I try to use a 1D array of booleans to select rows from a 2D array you get a crash right now. Not a Not implemented error.
np_boxes
is a 2D array of (x, y, w, h, score, class).
filtered_boxes = np_boxes[np_boxes[:, 4] > 0.0]
The above crashes.
If I try to use a 1D array of booleans to select rows from a 2D array you get a crash right now. Not a Not implemented error.
np_boxes
is a 2D array of (x, y, w, h, score, class).filtered_boxes = np_boxes[np_boxes[:, 4] > 0.0]
The above crashes.
OK, this is a different issue then, thanks for bringing it up! I opened a ticket here https://github.com/v923z/micropython-ulab/issues/672, so that it can be addressed.
Describe the solution you'd like I would like if append() and vstack() could be implemented.
Also if this limitation could be removed.
Additional context I was trying to implement non-max-suppression using Ulab and ran into the lack of these features complicating things for me.
Happy to finance this work.