search

v923z / micropython-ulab

a numpy-like fast vector module for micropython, circuitpython, and their derivatives
https://micropython-ulab.readthedocs.io/en/latest
MIT License
419 stars 115 forks source link

numpy/random.c: fix use of MICROPY_PY_RANDOM_SEED_INIT_FUNC #684

Closed dhalbert closed 1 month ago

dhalbert commented 1 month ago

In numpy/random.c:

The preprocessor guard for MICROPY_PY_RANDOM_SEED_INIT_FUNC was not complete: the value was used even if it was undefined.

There were also inconsequential trailing spaces and a trailing newline that were cleaned up by emacs when I edited the file.

dhalbert commented 1 month ago

FYI, we're merging micropython v1.23 into circuitpython, and this was a blocker (though we may need to turn off some functionality like random if it's not fitting on some boards).

dhalbert commented 1 month ago

I don't know what to make of the build failures, but I think they are unrelated.

v923z commented 1 month ago

I don't know what to make of the build failures, but I think they are unrelated.

Yeah, that's totally unrelated, I'd just let it pass for now. I've meant to fix that, but I forgot. Thanks for bringing it up!

v923z commented 1 month ago

In numpy/random.c:

The preprocessor guard for MICROPY_PY_RANDOM_SEED_INIT_FUNC was not complete: the value was used even if it was undefined.

There were also inconsequential trailing spaces and a trailing newline that were cleaned up by emacs when I edited the file.

Many thanks!