search

v9fs / linux

Linux kernel source tree
Other
2 stars 2 forks source link

fsync fscache operations in write_inode are questionable #28

Closed ericvh closed 1 year ago

ericvh commented 1 year ago

During fsync operations (in v9fs_write_inode) we send a sync operation to the server and clear the writeback in fscache -- but its not clear to me we actually flush the writeback buffers (unless this is happening before write_inode is called or as part of the fscache_unpin_writeback). We need to trace and verify

ericvh commented 1 year ago

These were indeed wrong - this has now been corrected. Still an open question as to whether or not this should include a flush, but that moment the lack of flush isn't failing any tests