search

v9y / giit

ISB source files for giitaayan
https://www.giitaayan.com
6 stars 4 forks source link

Update 833.isb #107

Closed porcupyn closed 5 years ago

porcupyn commented 5 years ago

Added missing stanza and corrected a few typos. Have a couple of questions.

BTW, I made a couple of other changes today, but don't think I've checked them back in properly. Vinay, can you review please?

morosebose commented 5 years ago

Hey @porcupyn, good to see your contributions! Could you please follow these suggestions for best practices?

  1. Create a new pull request for each song. Don't bundle multiple songs into the same pull request.
  2. Instead of working off master, create a new branch for each song that you want to update. That way, we won't have multiple folks trying to update the master branch at once, in case you're working on a song and I'm working on a different song.

Hope this is helpful!

morosebose commented 5 years ago

Whoops, also remove stanza number for the second stanza.

Sorry, if this were a separate branch I'd have downloaded this and just done a fresh commit/PR but I don't know how to handle an unmerged commit into master.

morosebose commented 5 years ago

Oh wait I just realized these changes were on porcupyn:master and not the actual v9y:master, duh. Sorry about that.

porcupyn commented 5 years ago

Also, I disagree with the correction of dulhan to dulian (sic). The correct word is dulhan whether or not the singer sings it as dulhin, no? Else, we would have to change 'pahali' to 'peheli' etc.

v9y commented 5 years ago

dulian was a typo (I don't know how that happened). Fixed that. Thanks for pointing out.

In both speech and written forms 'dulhin' is a valid variant and is often used. No one writes pahali as peheli (or even speaks it that way - This is more of a general pronunciation rule in Hindi - the sound of 'a' changes slightly to laghu 'e' if it is followed by 'ha'). In cases where there are multiple accepted variants, we should try to approximate the spoken version in transcribing.

porcupyn commented 5 years ago

Cool! I've been so long outside India that I've really got to think hard to figure out if I've even heard "dulhin" or "dulhan" more often! And I'm unsuccessful in answering that question!

BTW, did you see my other pull request? Have I done that properly?

Thanks,

On Fri, Aug 2, 2019 at 9:46 AM v9y notifications@github.com wrote:

dulian was a typo (I don't know how that happened). Fixed that. Thanks for pointing out.

In both speech and written forms 'dulhin' is a valid variant and is often used. No one writes pahali as peheli (or even speaks it that way - the slight laghu 'e'-ish sound that many people use before 'ha' and not 'li' - This is more of a general pronunciation rule in Hindi - the sound of 'a' changes slightly to laghu 'e' if it is followed by 'ha'). In cases, where there are multiple accepted variants, we should try to approximate the spoken version in transcribing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ32XTYGVM7PDKOOQDV3QCQ3E7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NZJMQ#issuecomment-517706930, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ35K73FFM6SUJZ6PH6TQCQ3E7ANCNFSM4HM3KIVQ .

v9y commented 5 years ago

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

porcupyn commented 5 years ago

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ .

morosebose commented 5 years ago

Porky,

You likely don't have merge access to the main repo. Are you issuing pull requests against Vinay's master or your local copy? We won't see requests made only against your copy.

On Aug 02, 2019, at 09:23 AM, porcupyn notifications@github.com wrote:

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRCGVN6QWWU54AMIZ3QCRNP3A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OG4RI#issuecomment-517762629, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWQ5QWA55IWZB5AH6HGTATQCRNP3ANCNFSM4HM3KIVQ.

porcupyn commented 5 years ago

I bet that's what I'm doing. :-(

Like I've said, I'm learning github. How exactly does it work? In the version control we have at work, I don't have a local version (like I appear to be doing for the giitaayan files @ github). But I thought I was supposed to do that for giitaayan, or did I misunderstand?

Also, a question about FITB - is there a specific sequence I can use? If not, how do I know the latest number already used?

On Fri, Aug 2, 2019 at 12:46 PM Surajit A Bose notifications@github.com wrote:

Porky,

You likely don't have merge access to the main repo. Are you issuing pull requests against Vinay's master or your local copy? We won't see requests made only against your copy.

  • Surajit

On Aug 02, 2019, at 09:23 AM, porcupyn notifications@github.com wrote:

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRCGVN6QWWU54AMIZ3QCRNP3A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OG4RI#issuecomment-517762629>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABWQ5QWA55IWZB5AH6HGTATQCRNP3ANCNFSM4HM3KIVQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ337CXIA45VTRPWZI2TQCRQF7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OIV2Q#issuecomment-517769962, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ346WWLI43HVGFVN6MTQCRQF7ANCNFSM4HM3KIVQ .

morosebose commented 5 years ago

There isn't a good reason to maintain your own clone of the giitayan repo. As long as you have permissions to create a branch off of the master branch of Vinay's repo, you can make changes to that branch via commits. When the changes look good, you can issue a pull request. At that time, Vinay (or anybody else with permissions) can look at the changes you've made, make comments and/or other commits, and (once everyone is satisfied) pull those changes into the master branch. After that, you can delete the branch you had created as all its changes are now in master.

Make sense?

On Aug 02, 2019, at 11:38 AM, porcupyn notifications@github.com wrote:

I bet that's what I'm doing. :-(

Like I've said, I'm learning github. How exactly does it work? In the version control we have at work, I don't have a local version (like I appear to be doing for the giitaayan files @ github). But I thought I was supposed to do that for giitaayan, or did I misunderstand?

Also, a question about FITB - is there a specific sequence I can use? If not, how do I know the latest number already used?

On Fri, Aug 2, 2019 at 12:46 PM Surajit A Bose notifications@github.com wrote:

Porky,

You likely don't have merge access to the main repo. Are you issuing pull requests against Vinay's master or your local copy? We won't see requests made only against your copy.

  • Surajit

On Aug 02, 2019, at 09:23 AM, porcupyn notifications@github.com wrote:

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRCGVN6QWWU54AMIZ3QCRNP3A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OG4RI#issuecomment-517762629>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABWQ5QWA55IWZB5AH6HGTATQCRNP3ANCNFSM4HM3KIVQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ337CXIA45VTRPWZI2TQCRQF7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OIV2Q#issuecomment-517769962, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ346WWLI43HVGFVN6MTQCRQF7ANCNFSM4HM3KIVQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QXZEPKAQHXJQ7GKJFDQCR5KTA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ORBHQ#issuecomment-517804190, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWQ5QTEMJKTGQP3RGU5AXTQCR5KTANCNFSM4HM3KIVQ.

porcupyn commented 5 years ago

Makes sense - thanks - but it appears that I created a clone when I was creating a branch. Or did I create a branch which I now think is a clone? How do I tell them apart?

On Fri, Aug 2, 2019 at 5:38 PM Surajit A Bose notifications@github.com wrote:

There isn't a good reason to maintain your own clone of the giitayan repo. As long as you have permissions to create a branch off of the master branch of Vinay's repo, you can make changes to that branch via commits. When the changes look good, you can issue a pull request. At that time, Vinay (or anybody else with permissions) can look at the changes you've made, make comments and/or other commits, and (once everyone is satisfied) pull those changes into the master branch. After that, you can delete the branch you had created as all its changes are now in master.

Make sense?

  • Surajit

On Aug 02, 2019, at 11:38 AM, porcupyn notifications@github.com wrote:

I bet that's what I'm doing. :-(

Like I've said, I'm learning github. How exactly does it work? In the version control we have at work, I don't have a local version (like I appear to be doing for the giitaayan files @ github). But I thought I was supposed to do that for giitaayan, or did I misunderstand?

Also, a question about FITB - is there a specific sequence I can use? If not, how do I know the latest number already used?

On Fri, Aug 2, 2019 at 12:46 PM Surajit A Bose <notifications@github.com

wrote:

Porky,

You likely don't have merge access to the main repo. Are you issuing pull requests against Vinay's master or your local copy? We won't see requests made only against your copy.

  • Surajit

On Aug 02, 2019, at 09:23 AM, porcupyn notifications@github.com wrote:

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318

,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRCGVN6QWWU54AMIZ3QCRNP3A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OG4RI#issuecomment-517762629 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABWQ5QWA55IWZB5AH6HGTATQCRNP3ANCNFSM4HM3KIVQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ337CXIA45VTRPWZI2TQCRQF7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OIV2Q#issuecomment-517769962 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AL3TZ346WWLI43HVGFVN6MTQCRQF7ANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QXZEPKAQHXJQ7GKJFDQCR5KTA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ORBHQ#issuecomment-517804190>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABWQ5QTEMJKTGQP3RGU5AXTQCR5KTANCNFSM4HM3KIVQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ36F5YZTDOLTHVIOKXTQCSSMHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3O4ULY#issuecomment-517851695, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ3YRSUJAZW7L7IPBLYLQCSSMHANCNFSM4HM3KIVQ .

morosebose commented 5 years ago

Branches are off a repo.

A repo can be cloned, which duplicates the repo in a different user space. That cloned repo, in turn, can have its own branches. Those will not propagate to the original repo.

To make changes to any given repo, create a branch, make commits against that branch, then issue a pull request to the owner of the repo.

If you are creating branches and making commits against your clone, rather than against Vinay's original, then changes you make won't make it to giitaayan, just to your clone. You need to create branches, make commits, and issue pull requests against Vinay's original repo.

(The above is a simplification, but it seems like the most helpful way to clarify things atm.)

On Aug 02, 2019, at 06:28 PM, porcupyn notifications@github.com wrote:

Makes sense - thanks - but it appears that I created a clone when I was creating a branch. Or did I create a branch which I now think is a clone? How do I tell them apart?

On Fri, Aug 2, 2019 at 5:38 PM Surajit A Bose notifications@github.com wrote:

There isn't a good reason to maintain your own clone of the giitayan repo. As long as you have permissions to create a branch off of the master branch of Vinay's repo, you can make changes to that branch via commits. When the changes look good, you can issue a pull request. At that time, Vinay (or anybody else with permissions) can look at the changes you've made, make comments and/or other commits, and (once everyone is satisfied) pull those changes into the master branch. After that, you can delete the branch you had created as all its changes are now in master.

Make sense?

  • Surajit

On Aug 02, 2019, at 11:38 AM, porcupyn notifications@github.com wrote:

I bet that's what I'm doing. :-(

Like I've said, I'm learning github. How exactly does it work? In the version control we have at work, I don't have a local version (like I appear to be doing for the giitaayan files @ github). But I thought I was supposed to do that for giitaayan, or did I misunderstand?

Also, a question about FITB - is there a specific sequence I can use? If not, how do I know the latest number already used?

On Fri, Aug 2, 2019 at 12:46 PM Surajit A Bose <notifications@github.com

wrote:

Porky,

You likely don't have merge access to the main repo. Are you issuing pull requests against Vinay's master or your local copy? We won't see requests made only against your copy.

  • Surajit

On Aug 02, 2019, at 09:23 AM, porcupyn notifications@github.com wrote:

I did something (merge) just now - do you see it now? It is for isb209

On Fri, Aug 2, 2019 at 12:16 PM v9y notifications@github.com wrote:

Sudarshan: I don't see any other PR pending. Can you check and try submitting again? Or please send me the URL if you see it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ33OKEIHWB7R5YJPYZLQCRMVHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGKPQ#issuecomment-517760318

,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/AL3TZ34GRBKACEBBKION5ATQCRMVHANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRCGVN6QWWU54AMIZ3QCRNP3A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OG4RI#issuecomment-517762629 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABWQ5QWA55IWZB5AH6HGTATQCRNP3ANCNFSM4HM3KIVQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ337CXIA45VTRPWZI2TQCRQF7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OIV2Q#issuecomment-517769962 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AL3TZ346WWLI43HVGFVN6MTQCRQF7ANCNFSM4HM3KIVQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QXZEPKAQHXJQ7GKJFDQCR5KTA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ORBHQ#issuecomment-517804190>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABWQ5QTEMJKTGQP3RGU5AXTQCR5KTANCNFSM4HM3KIVQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ36F5YZTDOLTHVIOKXTQCSSMHA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3O4ULY#issuecomment-517851695, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ3YRSUJAZW7L7IPBLYLQCSSMHANCNFSM4HM3KIVQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QRNR3XQA7J3QEXSGZTQCTNKLA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PEL2A#issuecomment-517883368, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWQ5QRKGMLDCLYLQDBXW3DQCTNKLANCNFSM4HM3KIVQ.

v9y commented 5 years ago

Surajit explained the whole concept well. Hope that helps. Another way to look at it:

Main Repo (v9y/giit)

porcupyn commented 5 years ago

Thanks Vinay and Surajit!

I understand (I think) now, but I am confused about one aspect.

It appears that the best and easiest way to make changes is to get a branch off the main repo and make changes then create a pull request. For some reason, I had the notion that I needed to create a forked repo. That is my misunderstanding, right? Or is that part of the best practices guidelines for giitaayan?

On Mon, Aug 5, 2019 at 9:24 AM v9y notifications@github.com wrote:

Surajit explained the whole concept well. Hope that helps. Another way to look at it:

Main Repo (v9y/giit)

  • Forked Repo (porcupyn/giit)
    • [Refresh your repo periodically from v9y/giit so that you get the changes made by others]
    • Create a branch or feel free to work directly on the porcupyn:master branch (since this is your repo and you are the only one using it)
      • [Optional] Clone forked repo locally on your machine. You can also instead work directly on github
        • Repeat as many times as needed:
          • Make changes
          • Commit changes
        • If you worked locally then push your changes back to your repo. Ignore if worked on github.
    • Create a pull request to merge your master into main repo's master

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ36ECDU4Y4YISS3TUUDQDASY7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3RZU7A#issuecomment-518232700, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ32QGAA55ZD4ALO6A6TQDASY7ANCNFSM4HM3KIVQ .

morosebose commented 5 years ago

Generally the reason to fork a repo is if you want to make changes to a codebase that are not necessarily going to make it back into the original. E.g., if you use an open source base but make proprietary changes to it, or if you're just experimenting with the code for your own purposes, or to learn. Or if you just want a redundant copy for safety/security reasons.

I did fork Vinay's original repo but eventually just cloned it to my local machine as I prefer to work in a text editor rather than a web interface. I update the fork from time to time to keep it current.

You asked about FITB serial numbers. Right now I just know that we've had 152 entries (including jab tak pure na ho) because I keep a list locally. I will publish it soon, I'm behind on a couple of ISB related projects (including some coding for Vinay around sequence numbers).

On Aug 05, 2019, at 07:10 AM, porcupyn notifications@github.com wrote:

Thanks Vinay and Surajit!

I understand (I think) now, but I am confused about one aspect.

It appears that the best and easiest way to make changes is to get a branch off the main repo and make changes then create a pull request. For some reason, I had the notion that I needed to create a forked repo. That is my misunderstanding, right? Or is that part of the best practices guidelines for giitaayan?

On Mon, Aug 5, 2019 at 9:24 AM v9y notifications@github.com wrote:

Surajit explained the whole concept well. Hope that helps. Another way to look at it:

Main Repo (v9y/giit)

  • Forked Repo (porcupyn/giit)
  • [Refresh your repo periodically from v9y/giit so that you get the changes made by others]
  • Create a branch or feel free to work directly on the porcupyn:master branch (since this is your repo and you are the only one using it)
  • [Optional] Clone forked repo locally on your machine. You can also instead work directly on github
  • Repeat as many times as needed:
  • Make changes
  • Commit changes
  • If you worked locally then push your changes back to your repo. Ignore if worked on github.
  • Create a pull request to merge your master into main repo's master

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=AL3TZ36ECDU4Y4YISS3TUUDQDASY7A5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3RZU7A#issuecomment-518232700, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3TZ32QGAA55ZD4ALO6A6TQDASY7ANCNFSM4HM3KIVQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/v9y/giit/pull/107?email_source=notifications&email_token=ABWQ5QUEGM7G2HEJM54IPOLQDAYEDA5CNFSM4HM3KIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3R55MI#issuecomment-518250161, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWQ5QXIKQKFIHOEYBKKSFDQDAYEDANCNFSM4HM3KIVQ.