vDawgg / awt-pj-ss24-finding_scenes-2

MIT License
1 stars 1 forks source link

use filename instead of title for generate_keyframes_from_scenes #41

Closed vDawgg closed 4 months ago

vDawgg commented 5 months ago

The name of the file the video is saved to is already cleaned. However, the title might contain characters that are not allowed for folder/file names (such as '/', '.', etc.). Therefore, the path should be made from the name of the video file, instead of the actual video title, as is done with the scene extraction.

As an example the current video downloaded in main.py will trigger an error, as the title contains a '.' at the end.

vDawgg commented 4 months ago

Fixed in b248c911a97a2420d906e7f9b8bef6982d73370d