vE5li / korangar

A next-gen Ragnarok Online client
MIT License
140 stars 32 forks source link

Properly implement packets 8302 and 180b #19

Open eleriaqueen opened 1 year ago

eleriaqueen commented 1 year ago

Currently packets 0x8302 and 0x180b don't have a correct name and are not handled. These two packets should be researched and implemented properly.

Some basic information from different sources:

Packet 0x283

rAthena (wiki): struct PACKET_ZC_AID { /* this+0x0 */ short PacketType /* this+0x2 */ unsigned long AID }

OpenKore (packetdescriptions.txt): 0283 Account ID

Packet 180b Info:

rAthena: ZC_EXTEND_BODYITEM_SIZE

Rust-RO (packets_db):

PACKET_ZC_INVENTORY_EXPANSION_INFO {
  short PacketId
  short expansionSize
}
eleriaqueen commented 1 year ago

Packet 0x283 is really redundant as it only sends to the client the player character's Game Object ID (it is their Account ID) which Korangar 100% already got from actually logging into the account and getting to character selection.

I'd say give it a name and add comment about it being redundant.