vKolerts / quest-sidenoder

Cross platform Sideloader for Quest standalone headset
MIT License
97 stars 20 forks source link

feat: fixed issue with quest 3, raised version of everything #51

Open javamachr opened 11 months ago

javamachr commented 11 months ago

Added workaround for Quest 3 write after end error on obb files sync. Raised version of everything to latest greatest. Should fix https://github.com/vKolerts/sidenoder/issues/38

yoanhg421 commented 11 months ago

Did this not get merged?. Can I clone your repo and build from there? I need this fix for my quest 3. Looks like a regular electron app. should run a build as such right?

javamachr commented 11 months ago

It did not work in the end. I'm still looking into it. Adb push keeps failing even if I run it via child_process. I'll release it once fixed from my repo.

yoanhg421 commented 11 months ago

Cool. Thank you. I’ll be on the lookout.

javamachr commented 11 months ago

Tested on mac with M1 - works there.

yoanhg421 commented 11 months ago

Yes. I was wondering. Tested on my m1 Mac last night and everything worked just fine on my Q3

javamachr commented 11 months ago

Whatever you tried before last commit(1 hour ago) did not actually work although the UI did not give any error. The real fix is the very last commit made 1 hour ago now the obb file copy really works.

yoanhg421 commented 11 months ago

Sorry, I did modify the if statement in the adbPush function because I thought it was redundant. I never tried it in the original state. I was going to test again today because I thought it was very weird I never got an error. Looks like that was it 👍.

Thanks for fixing this. I was having a lot of issues trying to run windows on Mac. Rookie kept giving me an error. Having tools that run natively helps so much 😁

DIEHARDave commented 11 months ago

So the sidenoder.Setup.win.0.8.0.exe uninstalls your old sidenoder then never installs 8. It seems it contains only arm64 binary.

javamachr commented 11 months ago

Right sorry I built it on arm - added sidenoder.Setup_winx64.0.8.0.exe could you give it a try? I don't have a windows machine available atm.

builtinhold commented 11 months ago

Thanks so much for this. Any chance you can add the Mac x64 0.8.0 version?

javamachr commented 11 months ago

Thanks so much for this. Any chance you can add the Mac x64 0.8.0 version?

Sure, I just added x64 mac v0.8.0 to the release in my fork.