search

vMeijin / pySmithPlot

Matplotlib extension for creating Smith charts with Python
127 stars 73 forks source link

Crash with Matplotlib 3.2.1 #29

Closed chrisgmorton closed 4 years ago

chrisgmorton commented 4 years ago

I personally find this package super useful. If I can help keep it alive please let me know. Here's a crash with the latest Matplotlib release. Hopefully the fix is quick and easy!

if i==j: self.axes.append(self.fig.add_subplot(n,n,1+i2+j, projection='smith')) File "/Users/chrisgmorton/fusion/prod/lib/python3.8/site-packages/matplotlib/figure.py", line 1401, in add_subplot self._process_projection_requirements(args, **kwargs) File "/Users/chrisgmorton/fusion/prod/lib/python3.8/site-packages/matplotlib/figure.py", line 1118, in _process_projection_requirements projection_class = projections.get_projection_class(projection) File "/Users/chrisgmorton/fusion/prod/lib/python3.8/site-packages/matplotlib/projections/init.py", line 56, in get_projection_class raise ValueError("Unknown projection %r" % projection) ValueError: Unknown projection 'smith'

alexpacini commented 4 years ago

I just tried and it is working fine for me with matplotlib-3.2.1 and numpy-1.18.5 on python3 on Linux. Did you import it?

from smithplot import SmithAxes

It registers the projection when the module is imported.

chrisgmorton commented 4 years ago

Okay, this was driver error as I had commented out the import line for the package. I'll close this one but I have a new issue will submit.