search

va3c / RvtVa3c

Revit va3c exporter
http://va3c.github.io/viewer/revit2.html
MIT License
268 stars 115 forks source link

Filter parameters error - Revit 2020 #18

Open jpstaub opened 3 years ago

jpstaub commented 3 years ago

Hello,

Thank you for all the work on the Revit JSON exporter add-in.

For some reason the exporter fails when trying to filter the parameters of the objects to be exported. Please see below for a sequence of photos showing the general flow of the failure.

I am very inexperienced Visual Studio user. If more debugging information is required to show what's happening please make a specific request and I'll see if I can produce it.

Please note, this may be the same issue reported earlier for Revit 2019 as issue #17.

Best wishes, Jake Staub

01_Filter parameters

02_Command Failure for External Command

03_Filter Error

jeremytammik commented 3 years ago

Thank you for pin-pointing this issue. the family instance category can be null. in that case, trying to read its name will throw the exception you see. i added a prior check for the null reference. please confirm that this fixes the issue. unfortunately, i did not implement this function myself.

jeremytammik commented 3 years ago

Here is the diff highlighting the fix: https://github.com/va3c/RvtVa3c/compare/2021.0.0.0...2021.0.0.1

jpstaub commented 3 years ago

Thank you for pin-pointing this issue. the family instance category can be null. in that case, trying to read its name will throw the exception you see. i added a prior check for the null reference. please confirm that this fixes the issue. unfortunately, i did not implement this function myself.

You are welcome.

Thanks for taking the time to post the fix. It resolved the problem.

Best wishes, Jake