va7deo / zerowing

Toaplan V1 system for MiSTer FPGA
GNU General Public License v2.0
46 stars 14 forks source link

OPL2 Audio [Issue] #43

Closed real-amano closed 6 months ago

real-amano commented 6 months ago

2 weeks ago Jotego found the culprit for this bug in his audio core and fixed it. Just to let you know since it is still mentioned in your readme.md.

See https://github.com/jotego/jtopl/issues/11

atrac17 commented 6 months ago

2 weeks ago Jotego found the culprit for this bug in his audio core and fixed it. Just to let you know since it is still mentioned in your readme.md.

See https://github.com/jotego/jtopl/issues/11

I'm tracking the commit, we'll see what the outcome gives.

atrac17 commented 6 months ago

@real-amano here is an updated build, let me know what you think.

Reference:

https://github.com/jotego/jtopl/issues/11 https://github.com/jotego/jtopl/commit/2829f61ceb26349b5682235ab8712cd1d6b4a53f https://github.com/va7deo/zerowing/commit/d9b25cbc17f190b4d523557570c1e0d93ac019bd

zerowing20240404.zip

sherhacky commented 6 months ago

@atrac17 In case it's helpful, here's a recording of some gameplay of Truxton on the updated build: https://youtu.be/4F8OBvQk-B8 Awesome: Instruments that were previously silent are now booming! I think there are still balance issues, as many of those same instruments are distorted/crunchy sounding. Below I'm relying on Sumez's 1cc YT vid on PCB as a source of truth.

atrac17 commented 6 months ago

Thanks, it'd be best to report this in https://github.com/jotego/jtopl/issues/11. It's vastly improved, but the implementation is still lacking all the percussion.

I've already tested everything, percussion is present now but not correct. There is no balancing or filtering to be done on the core side (per schematics); the issue lies in the OPL2 implementation.

I own Tatsujin, OutZone, and have measurements / recordings for all PCB's that fall under Toaplan1. You're more than welcome to address this with the author of the module. I suggest using OutZone as a reference, it's easiest to pinpoint that there are still percussion samples missing or they're too quiet.

I'm already in the process of updating all the cores that utilize OPL or OPL2 and verifying improvement. Thanks for your detailed report. Below is the best track to verify OPL2 against taken from the OutZone PCB, it should be used for reference against track 02 in the service menu.

https://drive.google.com/file/d/1iQcNg3I362-YyhUKCtfUQ1FB1lqp7hVo/view?usp=sharing