Closed priestc closed 10 years ago
Thanks ! I've taken some time to look at your first commit. I amended it a little. The commit is in the temporary "pull-request-11" branch. You can check differences with "git diff afb7e96..pull-request-11" once you've fetched it. Tell me if anything seems wrong.
Main changes are:
To check if tests passes, you can use::
python -m doctest -d colour.py -d README.rst
I'm looking at your next commits (I'll probably use a dict to store the color-name association, as it seems more natural).
Hi, I've included your commit and made some amend to make sure that test passes. I have also added an other commit to change the datastructure. All these commits are in the pull-request-11 branch.
Feel free to tell me if it works for you. Of course, I have taken great care to keep you author of your commits.
Any comments are welcome. I'll wait your review to commit this branch as master and submit the resulting version to the PyPI.
I'm closing this because these commits where integrated.
The colors have been updated according to the wiki page: http://en.wikipedia.org/wiki/X11_color_names
W3G colors were used when the clash with X11 colors.
I have not tested this at all, as I can't figure out how the
autogen.sh
process works.