Use try, except instead of checking __dict__.

vaab / colour

Python color representations manipulation library (RGB, HSL, web, ...)

BSD 2-Clause "Simplified" License

322 stars 41 forks source link

Use try, except instead of checking dict. #12

Closed hellais closed 9 years ago

hellais commented 10 years ago

This allows you to create subclasses of colour.Color, since __dict__ is not inherited by subclasses.

vaab commented 9 years ago

Many thanks. Sorry for being so late, I figure it's better sooner than later, I don't know why your PR was left alone like this. But first, it doesn't pass the test ! and a new test demonstrating the bug would have been great. I had to add a protection against infinite recursion to make it pass the tests.

Many thanks for the feedback, and you have been kept as the author of the commit.

vaab / colour

Use try, except instead of checking __dict__. #12

Use try, except instead of checking dict. #12