Various python 3.x compatibility fixes

vaab / colour

Python color representations manipulation library (RGB, HSL, web, ...)

BSD 2-Clause "Simplified" License

322 stars 41 forks source link

Various python 3.x compatibility fixes #4

Closed mehcode closed 11 years ago

mehcode commented 11 years ago

Moved into a 1-file package so that rgb.txt can be included easily.
Various python 3.x compatibility fixes. Tests pass in both python 2.x and 3.x.

vaab commented 11 years ago

Thank you for your contribution. I'm looking into the 3k compatibility layer, but I would have rather prefered that topics wouldn't be merged in one commit.

You have mixed pure syntax 3k compatibility concerns with package related refactor (moving around files and touched setup.py). I'll take time to consider if the last part is necessary.

Anyway, thanks for this contribution. It's maybe time for me to consider Travis and both python2 & python3k test build.

I'll keep this pull request open until your contribution to make colour python3k friendly is cleanly merged with trunk (and make sure you are properly credited of course).

More info soon.

mehcode commented 11 years ago

My apologies. I've split the changes. The only things left are the fixes for python3.

mehcode commented 11 years ago

Aww.. My build fails travis because it thinks its ruby. Amusing. To make a note. You need a .travis.yml that tells it do run python -m doctest -v colour.py.

vaab commented 11 years ago

I've used your pull request to cherry-pick your modification and I went through the diff. This is the result:

https://github.com/vaab/colour/tree/python3

This branch is on top of "git-installability", and more important "travis" branch which adds .travis.yml file.

I've done some small amends modification to your contribution:

added python "3.3" tests for travis
removed the 'list' where I thought they were not usefull
kept both tests on nonexistent color specifier and did a slight modification to them so they pass in python 3

Could you confirm this doesn't hurt poneys without me noticing ?, and I'll merge master with this branch.

Of course, Travis did give its benediction on all this.

mehcode commented 11 years ago

The autogen branch hurts many ponies; kills them in fact. gitchangelog is not python 3 compatible so pip goes in an infinite loop. You may be able to fix it by just adding use_2to3=True to the setup function in setup.py of gitchangelog.

vaab commented 11 years ago

Oh crap. I definitively don't want that a failure of gitchangelog (whatever the reason) generates an infinite loop.

Sorry for the ponies. You're a hero.

I rebased python3 branch, it should work now. I've simulated gitchangelog failing, but if you could test colour's git-install-ability with your full python3 environment, and tell me that it works, that would rejoice me...

mehcode commented 11 years ago

Everything seems to work on my end. :shipit:

vaab commented 11 years ago

Merged in master and pushed on PyPI: https://pypi.python.org/pypi/colour/0.0.3 Thanks.

mehcode commented 11 years ago

I appreciate the quick response on the python 3.x stuff. I was expecting to have to wait quite awhile. Thanks. Have a cookie. :cookie: