search

vaab / colour

Python color representations manipulation library (RGB, HSL, web, ...)
BSD 2-Clause "Simplified" License
322 stars 41 forks source link

Package is not git-install-able #5

Closed mehcode closed 11 years ago

mehcode commented 11 years ago

Because of the following reasons, this package is not install-able from git:

vaab commented 11 years ago

you need to run ./autogen.sh ... I need to add this to the doc. Sorry for inconvenience. I keep this Issue open to remind me to add this to the doc. (note that CHANGELOG.rst is created thanks to gitchangelog also, that is installable with pip install gitchangelog).

I hope to find some time tomorrow.

mehcode commented 11 years ago

I did pip install gitchangelog and ./autogen.sh. I was able to figure out that much. It then complained there was no configuration for gitchangelog; that's when I gave up trying to run it.

vaab commented 11 years ago

Yup, and that's an issue and should'nt be. (missing .gitchangelog.rc as https://github.com/0k/shyaml/blob/master/.gitchangelog.rc and you couldn't/shouldn't have to figure this out).

Thanks for the feedback, and sorry for the inconvenience.

mehcode commented 11 years ago

Thanks for the response.

I should further note that you should strive to make the following command work as sometimes its nice to be able to depend on specific branches or commits from setup.py.

pip install git+git://github.com/vaab/colour.git

The process involving autogen.sh doesn't have a chance to get executed.

vaab commented 11 years ago

Didn't know about this, will look into it. Having version and changelog generated through git is quite helpfull though, I'd like to keep it if possible. If you have any ref not obvious documenting this, feel free to share.

mehcode commented 11 years ago

If you mean depending on packages via a git reference. Check http://pythonhosted.org/distribute/setuptools.html#dependencies-that-aren-t-in-pypi for the documentation and one of my repositories like https://github.com/concordusapps/sqlalchemy-utils/blob/python3/setup.py#L31-L32 for an example.

If you mean generating version / changelog through git; the way your doing it currently is fine. Just keep the current version of stuff checked in so its install-able through setuptools alone.

vaab commented 11 years ago

I've looked on this functionality, as I understand it, I should renounce to either:

I'm afraid that as far as I'm concerned, I'll remain incompatible with this kickass feature of pip.

Nonetheless, independently to this topic, the install was completely screwed:

So as to irremediably sink in your estimation, I've broken the sacred oath of rewriting published history (with the pity excuse that it was already messed up). I hope that the fact there was only 3 commit involved will reduce your possible wrath.

Anyway, git fetch && git stash && git reset --hard origin/master could be of some help. I'll manage all the hassle with your other push request concerning python 3 compatibily concerns, it isn't an issue for me.

This new master branch should make ./autogen.sh work properly with gitchangelog and set version in setup.py accordingly.

Please note that I've also added an INSTALL section in the README.rst which states the need to launch autogen.sh in order to get configured and usable source tree.

I would be happy to get your feedback on these changes. I'll wait to get your confirmation that it is indeed working for you before closing this issue.

Many thanks for your interest and your report.

PS: there might be a solution inspired from my last commit d82e7fade0de9d20ba1bd55176fd268a94db2a09 that could run autogen.sh if it has not already be run (this means that pip would have to actually clone the repository and run a real python setup.py install in the repository, which he might already does).

mehcode commented 11 years ago

So as to irremediably sink in your estimation, I've broken the sacred oath of rewriting published history (with the pity excuse that it was already messed up). I hope that the fact there was only 3 commit involved will reduce your possible wrath.

The history of git is merely a canvas on which to paint whatever takes one's fancy. One rewrite begets another as you'll see in #4.

I would be happy to get your feedback on these changes. I'll wait to get your confirmation that it is indeed working for you before closing this issue.

It does work. I must admit to some disappointment that pip install git+git://... won't be fixed or working but we take what we can get.

PS: there might be a solution inspired from my last commit d82e7fa that could run autogen.sh if it has not already be run (this means that pip would have to actually clone the repository and run a real python setup.py install in the repository, which he might already does).

Now this is something. This could work.

mehcode commented 11 years ago

Many thanks for your interest and your report.

Just so we're clear. I'm not interested in actually using this project so at best I have a reserved interest. I just wished to get https://github.com/kvesteri/sqlalchemy-utils compatible with python 3.x and this package was a dependency of it.

vaab commented 11 years ago

Well, let's say that taking time to send a pull request and report poor packaging is what I call "interest". So... many thanks for that, whatever you call it.

Happy to see that it works for you.

You might want to check: https://github.com/vaab/colour/tree/auto-autogen

And try:

pip install git+https://github.com/vaab/colour.git@auto-autogen

It works on my test environment (pip==1.3.1, python 2.7, ubuntu 12.04)