VBump component version to 23.0.0

vaadin-component-factory / enhanced-dialog

Java API for vcf-enhanced-dialog component

https://incubator.app.fi/enhanced-dialog-demo/enhanced-dialog

Apache License 2.0

1 stars 3 forks source link

VBump component version to 23.0.0 #18

Closed hfazai closed 2 years ago

hfazai commented 2 years ago

This is to support upgrade to V22.0.6 after releasing a new component version. https://github.com/vaadin-component-factory/vcf-enhanced-dialog/pull/5

Update: now targeting V23.0.0

hfazai commented 2 years ago

@jcgueriaud1 could you please review this?

hfazai commented 2 years ago

@jcgueriaud1 could you please also release a version for V22, because V23 doesn't support Java 8 and some people will take a time to migrate to Java11 so at the meanwhile they will be able to continue using EnhancedDialog.

jcgueriaud1 commented 2 years ago

The Vaadin 23 version of the addon has been released.

hfazai commented 2 years ago

@jcgueriaud1 Great, Thanks! And what about V22 are planning to create a release?

jcgueriaud1 commented 2 years ago

If you need it, I can do it next week but I would rather put my effort in something else.

hfazai commented 2 years ago

Yes if that doesn't take you too much time.

Actually I workaround it with extending EnhancedDialog and annotating it with @NpmPackage(value = "@vaadin-component-factory/vcf-enhanced-dialog", version = "22.0.6")

It's working fine but has some side effects:

showing this warning : Multiple npm versions for @vaadin-component-factory/vcf-enhanced-dialog found: [22.0.6, 21.0.0]. First version found '22.0.6' will be considered.
And sometimes failing when doing live reload.

jcgueriaud1 commented 2 years ago

I published a Vaadin 22 version of the component, can you try it and tell me if it's working?

hfazai commented 2 years ago

@jcgueriaud1 yup, it works fine thanks 👍