vaadin-component-factory / lookup-field-flow

Java API for a Lookup Field in Vaadin
https://componentfactory.app.fi/lookup-field-flow-demo/
Apache License 2.0
0 stars 1 forks source link

Cannot read properties of undefined (reading 'assignedNodes') in custom filter view #17

Closed jcgueriaud1 closed 1 year ago

jcgueriaud1 commented 1 year ago

The pages in the demo app are not working: http://localhost:8080/custom-filter-type and http://localhost:8080/custom-filter

There is a javascript error: Cannot read properties of undefined (reading 'assignedNodes')

jcgueriaud1 commented 1 year ago

image

brunovianarezende commented 1 year ago

it seems like this error was caused by this commit: https://github.com/vaadin-component-factory/vcf-lookup-field/commit/5e0c58fc5a902c0d7fea4bd02a81f7afc2882794#diff-0f293deae2e17960a353c9b5ad73658ca8dc14a2f8426c88793cc1f1ce3fe15aR200

there is a typo there:

this._filter = this.$.filterSolt.assignedNodes()[0];

should be

this._filter = this.$.filterSlot.assignedNodes()[0];

(filterSlot instead of filterSolt)

brunovianarezende commented 1 year ago

https://github.com/vaadin-component-factory/vcf-lookup-field/pull/7

bwajtr commented 1 year ago

I've reviewed and tested the PR - all seems OK. Merged

bwajtr commented 1 year ago

Fixed in web-component release 23.3.1 included in Flow component version 23.3.5