search

vaadin-component-factory / selection-grid-flow

Add the functionality to Vaadin Grid to focus on a particular row and column and select a range of rows with SHIFT/CTRL Click
https://incubator.app.fi/selection-grid-flow-demo/
Apache License 2.0
5 stars 8 forks source link

selectRangeOnly() called multiple times #45

Open danielstieger opened 1 year ago

danielstieger commented 1 year ago

The _selectionGridSelectRowWithItem() in the helper.js is a bit weired. In case the shiftKey and the ctrlKey is not active, the selectRangeOnly is called in line 43 and in 74. Is this on purpose? Or is there a early return missing in line 45? Or an else if instead of the if in line 50?

randomuser1231232 commented 1 year ago

In my case selectRangeOnly() is sometimes called ad infinitum causing the server to do nothing but selectRangeOnly() even after the client was closed. All further connections are fruitless and the server has to be killed. This is somewhat reproducible.