vaadin-component-factory / vcf-date-range-picker

Apache License 2.0
1 stars 4 forks source link

Builds no longer work with Vaadin Flow 23.3.27 and vcf-date-range-picker 4.0.1 #40

Open pgould-taskize opened 7 months ago

pgould-taskize commented 7 months ago

After last week's release of Vaadin Flow 23.4.0, existing builds using Vaadin 23.3.27 and vcf-date-range-picker 4.0.1 have stopped working.

Upon browsing to http://localhost:8080, the following is written to the console and the application just hangs (with blue loading bar):

Uncaught (in promise) DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "vaadin-overlay" has already been used with this registry
    at window.customElements.define (http://localhost:8080/:4:829)

To reproduce in a minimal fashing, I created the following Vaadin starter app:

image

Set the vaadin.version to 23.3.27:

        <vaadin.version>23.3.27</vaadin.version>

and added the vcf-date-range-picker dependency:

        <dependency>
            <groupId>com.vaadin.componentfactory</groupId>
            <artifactId>vcf-date-range-picker</artifactId>
            <version>4.0.1</version>
        </dependency>

Build and start the app:

mvn clean install
java -jar target/spring-skeleton-1.0-SNAPSHOT.jar

Navigate to http://localhost:8080. Look at the console logs - the DOMException is shown.

Here is the sample app for your convenience:

skeleton-starter-flow-spring-23.3.27.zip

pgould-taskize commented 7 months ago

Although upgrading to Vaadin 23.4.0 is an option, I'd like to understand why the release of 23.4.0 entirely broke the application build.

paodb commented 7 months ago

The release of Vaadin Flow 23.4.0 shouldn't affect those who are using version 23.3.27, unless it's explicitly specified in the pom.xml file that version 23.4.0 should be used. I've reviewed the project you shared and there's no presence of Flow 23.4.0. I did some testing, running the project in dev and in prod modes, and it works correctly with Vaadin version 23.3.27 and Date Range Picker version 4.0.1. It seems that the issue might be related to other aspects of the development environment or specific project configuration.