search

vaadin-component-factory / vcf-pdf-viewer-flow

Vaadin Addon for providing pdf viewing functionality
Apache License 2.0
8 stars 6 forks source link

Attach onto to amend to init #36

Open weiliang2 opened 1 year ago

weiliang2 commented 1 year ago

Hi there,

consider changing "attached on" to init at constructor. We can reuse the component in a application, instead of recreating the object always.

We can just set the src link for the anchor and it should update the download and print button.

Also if you can add support to vaadin 14 would be really helpful.

Great work! This should be a default component.

Thanks for reading.