search

vaadin / archetypes

Archetypes for Vaadin platform
https://vaadin.com
4 stars 7 forks source link

Update vertical and horizontal layout spacing and margins #114

Closed hesara closed 7 years ago

hesara commented 7 years ago

This is related to the change of defaults in vaadin/framework8-issues#526 .

Addresses parts of vaadin/framework8-issues#559 .

This change is Reviewable

hesara commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.

vaadin-archetype-application-example/src/main/resources/archetype-resources/rootArtifactId-ui/src/main/java/samples/crud/SampleCrudView.java, line 59 at r1 (raw file):

        barAndGridLayout.addComponent(topLayout);
        barAndGridLayout.addComponent(grid);
        barAndGridLayout.setMargin(false);

incorrect values

Comments from Reviewable

hesara commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, all discussions resolved.

vaadin-archetype-application-example/src/main/resources/archetype-resources/rootArtifactId-ui/src/main/java/samples/crud/SampleCrudView.java, line 59 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…
incorrect values

Fixed

Comments from Reviewable

pleku commented 7 years ago

Reviewed 11 of 12 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable