Fix PWA annotations - Githubissues

vaadin / bakery-app-starter-flow-spring

Internal repository for Bakery App Starter for Flow and Spring

The Unlicense

6 stars 12 forks source link

Fix PWA annotations #691

Open Peppe opened 5 years ago

Peppe commented 5 years ago

From @PWA in MainView

Remove reference to manifest.json. It does not exist anymore.
The icon for the app is never used and now the default vaadin pwa icon is in place. Reference the icon.png.

alvarezguille commented 5 years ago

Quick research showed that iconPath in @PWA already defaults to icons/icon.png so there should be no need to specify it, but it's not working as expected.

alexberazouski commented 5 years ago

Regarding manifest.json: the default value is manifest.webmanifest. We could switch to the defaults, but do not forget to change the security config to allow access to the new path.