search

vaadin / bakery-app-starter-fw8-spring

Internal repository for Bakery App Starter for FW8 and Spring
Other
0 stars 2 forks source link

fix the dashboard layout in IE11 #482

Closed vlukashov closed 6 years ago

vlukashov commented 6 years ago

Fix #393

Jira: DASH-137

This change is Reviewable

vaadin-bot commented 6 years ago

SonarQube analysis reported 3 issues

Watch the comments in this conversation to review them.

vlukashov commented 6 years ago

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.

src/main/java/com/vaadin/starter/bakery/ui/view/dashboard/BoardBox.java, line 6 at r2 (raw file):

Previously, vaadin-bot (Vaadin Bot) wrote…
![INFO](https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO') Override the "equals" method in this class. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS2160)

won't fix: other components extending the CssLayout class do not override equals()

src/main/webapp/VAADIN/themes/apptheme/_dashboardview.scss, line 123 at r2 (raw file):

Previously, vaadin-bot (Vaadin Bot) wrote…
![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove the useless trailing whitespaces at the end of this line. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=scss%3AS1131)

fixed in #483 - a separate PR with only formatting changes

src/main/webapp/VAADIN/themes/apptheme/_dashboardview.scss, line 129 at r2 (raw file):

Previously, vaadin-bot (Vaadin Bot) wrote…
![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove the useless trailing whitespaces at the end of this line. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=scss%3AS1131)

fixed in #483 - a separate PR with only formatting changes

Comments from Reviewable

tulioag commented 6 years ago
:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

tulioag commented 6 years ago

Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/main/java/com/vaadin/starter/bakery/ui/view/dashboard/BoardBox.java, line 6 at r2 (raw file):

Previously, vlukashov (Viktor Lukashov) wrote…
won't fix: other components extending the `CssLayout` class do not override `equals()`

OK

src/main/webapp/VAADIN/themes/apptheme/_dashboardview.scss, line 123 at r2 (raw file):

Previously, vlukashov (Viktor Lukashov) wrote…
fixed in #483 - a separate PR with only formatting changes

OK

src/main/webapp/VAADIN/themes/apptheme/_dashboardview.scss, line 129 at r2 (raw file):

Previously, vlukashov (Viktor Lukashov) wrote…
fixed in #483 - a separate PR with only formatting changes

OK

Comments from Reviewable