vaadin / bakery-app-starter-fw8-spring

Internal repository for Bakery App Starter for FW8 and Spring
Other
0 stars 2 forks source link

rename com.vaadin.starter.bakery.ui.view into views #488

Closed vlukashov closed 6 years ago

vlukashov commented 6 years ago

to align with Bakery for Flow


This change is Reviewable

manolo commented 6 years ago

Apparently CI fails, but passes in my local so :lgtm:


Review status: 0 of 74 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

manolo commented 6 years ago

Reviewed 143 of 143 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

vaadin-bot commented 6 years ago

SonarQube analysis reported 57 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR AbstractCrudPresenter.java#L184: Either remove or fill this block of code. rule
  2. MAJOR AbstractCrudPresenter.java#L220: Either log or rethrow this exception. rule
  3. MAJOR AbstractCrudView.java#L144: Remove usage of generic wildcard type. rule
  4. MAJOR AbstractCrudView.java#L144: Remove usage of generic wildcard type. rule
  5. MAJOR OrderEditView.java#L217: Remove usage of generic wildcard type. rule
  6. MAJOR ProductInfo.java#L122: Remove usage of generic wildcard type. rule
  7. MINOR DashboardView.java#L248: Remove this empty statement. rule
  8. INFO AbstractCrudPresenter.java#L36: Make "service" transient or serializable. rule
  9. INFO AbstractCrudPresenter.java#L47: Make "beanFactory" transient or serializable. rule
  10. INFO ProductAdminDataProvider.java#L23: Make "productService" transient or serializable. rule
manolo commented 6 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 7 unresolved discussions.


Comments from Reviewable

manolo commented 6 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, 7 unresolved discussions.


Comments from Reviewable