Closed vlukashov closed 7 years ago
Reviewed 1 of 1 files at r2, 1 of 1 files at r3. Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
precompiled/src/main/frontend/bower.json, line 16 at r4 (raw file):
"webcomponentsjs": "1.0.2"
should this be "webcomponentsjs": "^1.0.0"
so that there is no issue with next webcomponentsjs minor?
Comments from Reviewable
Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
precompiled/src/main/frontend/bower.json, line 16 at r4 (raw file):
> "webcomponentsjs": "1.0.2" should this be `"webcomponentsjs": "^1.0.0"` so that there is no issue with next webcomponentsjs minor?
fixed
Comments from Reviewable
Reviewed 1 of 1 files at r4. Review status: 2 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Reviewed 1 of 1 files at r5. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Key changes:
bower_components
and other front-end build folders into the clean list formvn clean
(to avoid the same issue in the future)This change is![Reviewable](https://reviewable.io/review_button.svg)