Fix failing maven builds (fix #108)

vaadin / board

Framework 8 version of vaadin-board

Other

8 stars 10 forks source link

Fix failing maven builds (fix #108) #109

Closed vlukashov closed 7 years ago

vlukashov commented 7 years ago

Key changes:

add bower_components and other front-end build folders into the clean list for mvn clean (to avoid the same issue in the future)
bump the version of WebComponents polyfills up to 1.0.2 to match with the requirements of vaadin-board 1.0.1

This change is

CLAassistant commented 7 years ago

All committers have signed the CLA.

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r2, 1 of 1 files at r3. Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

precompiled/src/main/frontend/bower.json, line 16 at r4 (raw file):

"webcomponentsjs": "1.0.2"

should this be "webcomponentsjs": "^1.0.0" so that there is no issue with next webcomponentsjs minor?

Comments from Reviewable

vlukashov commented 7 years ago

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

precompiled/src/main/frontend/bower.json, line 16 at r4 (raw file):

Previously, alvarezguille (Guille) wrote…

> "webcomponentsjs": "1.0.2" should this be `"webcomponentsjs": "^1.0.0"` so that there is no issue with next webcomponentsjs minor?

fixed

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r4. Review status: 2 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r5. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable