Closed DiegoCardoso closed 6 years ago
integration-tests/src/main/java/com/vaadin/addon/board/examples/ImageCollage.java, line 98 at r1 (raw file):
CssLayout container = new CssLayout();
wasn't this container added as a wrapper initially?
Comments from Reviewable
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.
integration-tests/src/main/java/com/vaadin/addon/board/examples/ImageCollage.java, line 98 at r1 (raw file):
> CssLayout container = new CssLayout(); wasn't this container added as a wrapper initially?
Yes and no. Initially the container was to receive the styles (border, background, padding etc) and the second one to workaround the IE11 issue. But now I moved the styles to the image itself and made the initial container the only one needed.
Comments from Reviewable
Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
IE11 doesn't calculate
flex-basi
s well if element has margin, padding or border, even if it hasbox-sizing: border-box
. In order to prevent it to break, one can add a wrapper, so theflex-basis
will work.This change is![Reviewable](https://reviewable.io/review_button.svg)