vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Fix broken examples on IE11 #127

Closed DiegoCardoso closed 6 years ago

DiegoCardoso commented 6 years ago

IE11 doesn't calculate flex-basis well if element has margin, padding or border, even if it has box-sizing: border-box. In order to prevent it to break, one can add a wrapper, so the flex-basis will work.


This change is Reviewable

alvarezguille commented 6 years ago

integration-tests/src/main/java/com/vaadin/addon/board/examples/ImageCollage.java, line 98 at r1 (raw file):

CssLayout container = new CssLayout();

wasn't this container added as a wrapper initially?


Comments from Reviewable

DiegoCardoso commented 6 years ago

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


integration-tests/src/main/java/com/vaadin/addon/board/examples/ImageCollage.java, line 98 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
> CssLayout container = new CssLayout(); wasn't this container added as a wrapper initially?

Yes and no. Initially the container was to receive the styles (border, background, padding etc) and the second one to workaround the IE11 issue. But now I moved the styles to the image itself and made the initial container the only one needed.


Comments from Reviewable

alvarezguille commented 6 years ago

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable