search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Improve "Getting started" text and formatting #16

Closed marlonrichert closed 7 years ago

marlonrichert commented 7 years ago

This change is Reviewable

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 5 unresolved discussions.

documentation/webcomponents-api/getting-started.asciidoc, line 49 at r1 (raw file):

you should not include < >, [elementname]`` style adds them.

documentation/webcomponents-api/getting-started.asciidoc, line 81 at r1 (raw file):

[elementname]<div> you should not include < >, [elementname]`` style adds them. So now we double brackets.

documentation/webcomponents-api/getting-started.asciidoc, line 85 at r1 (raw file):

[elementname]<html> you should not include < >, [elementname]`` style adds them.

documentation/webcomponents-api/getting-started.asciidoc, line 85 at r1 (raw file):

[elementname]`< you should not include < >, [elementname]`` style adds them.

documentation/webcomponents-api/getting-started.asciidoc, line 103 at r1 (raw file):

the [elementname]<style> you should not include < >, [elementname]`` style adds them.

Comments from Reviewable

rogozinds commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 5 unresolved discussions.

Comments from Reviewable

alvarezguille commented 7 years ago

included in #17