search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Add getting started #17

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

This change is Reviewable

alvarezguille commented 7 years ago

Reviewed 2 of 3 files at r1. Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

documentation/webcomponents-api/getting-started.asciidoc, line 49 at r1 (raw file):

[elementname]html

what's expected from this? I think it should either be [elementname]#html# or html

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

documentation/webcomponents-api/getting-started.asciidoc, line 49 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
> [elementname]`html` what's expected from this? I think it should either be [elementname]#html# or `html`

That was made by mistake, here it means just HTML element not a tag changed.

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

documentation/webcomponents-api/getting-started.asciidoc, line 49 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
That was made by mistake, here it means just HTML element not a tag changed.

Done.

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable