vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Refactor overview docs #38

Closed alvarezguille closed 7 years ago

alvarezguille commented 7 years ago

This change is Reviewable

alvarezguille commented 7 years ago

Moves know issues and es6 to es5 transpilation docs from overview to WC basic use. Uses feature list from release notes.

rogozinds commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions.


documentation/board-overview.asciidoc, line 19 at r1 (raw file):

Not only does is Does is? Looks like should be one one of this.

Not only does is the component itself responsive The whole phrase sounds like a 100% TV-shop, I would just leave it.

"Each row reacts individually to the space given to it in a responsive way."


documentation/board-overview.asciidoc, line 21 at r1 (raw file):

this This The whole sentence is freaky complex. I Would change it:

This allows you to place one widget among multiple slots.


documentation/board-overview.asciidoc, line 22 at r1 (raw file):

You can put a new row within another row to build how ever complex layouts that you want This also sounds like TV-shop. Why do I want to build "Complex" layout? I want to build easy stuff, but just it should look good. I understand what you are trying to say, but it sounds like we are adding unnecessary complexity I would change it to: You can put one row within another to create different layouts and position you widgets how ever you want.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 4 unresolved discussions.


documentation/board-overview.asciidoc, line 21 at r2 (raw file):

. or 25-50-25. or 33-67.· Should it be commas? Or capital letter?


Comments from Reviewable

alvarezguille commented 7 years ago

Review status: 1 of 2 files reviewed at latest revision, 4 unresolved discussions.


documentation/board-overview.asciidoc, line 21 at r2 (raw file):

Previously, rogozinds (rogozinds) wrote…
> . or 25-50-25. or 33-67.· Should it be commas? Or capital letter?

Done.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

rogozinds commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable