search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Mention redraw() in basic use docs #4

Closed alvarezguille closed 7 years ago

alvarezguille commented 7 years ago

This change is Reviewable

Artur- commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

documentation/webcomponents-api/board-basic-use.asciidoc, line 75 at r1 (raw file):

=== Redraw method

Vaadin Board relies on window resize events to achieve responsiveness.

Doesn't it rely on IronResize events?

Comments from Reviewable

Artur- commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

rogozinds commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

documentation/webcomponents-api/board-basic-use.asciidoc, line 75 at r1 (raw file):

Previously, Artur- (Artur) wrote…
Doesn't it rely on IronResize events?

That's true.

Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

alvarezguille commented 7 years ago

documentation/webcomponents-api/board-basic-use.asciidoc, line 75 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
That's true.

sounds like implementation details, right now we have our own version of ironresize, do we want to go into that detail for docs?

Comments from Reviewable

Artur- commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

documentation/webcomponents-api/board-basic-use.asciidoc, line 75 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
sounds like implementation details, right now we have our own version of ironresize, do we want to go into that detail for docs?

Remove "window", then it is true

Comments from Reviewable

alvarezguille commented 7 years ago

documentation/webcomponents-api/board-basic-use.asciidoc, line 75 at r1 (raw file):

Previously, Artur- (Artur) wrote…
Remove "window", then it is true

sounds good, done!

Comments from Reviewable

Artur- commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable