search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Use new webcomponents-helper #54

Closed Legioth closed 7 years ago

Legioth commented 7 years ago

https://github.com/vaadin/framework/pull/9368 changes the API used by the webcomponents helper. This PR updates to use a new version of the helper that will work with framework versions after API change has been submitted.

This change is Reviewable

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

Legioth commented 7 years ago

Build fails with "License for Vaadin Board 1 not found." Hard to believe that it's caused by my patch, though it might be caused by the fact that this PR is from an external repository?

alvarezguille commented 7 years ago

Is this still relevant? Could you rebase it?

Legioth commented 7 years ago

It's still relevant, but won't cause any visible changes to board. Without the update, bundling of HTML imports won't work because com.vaadin.webcomponentshelper.htmlbundle.HtmlBundleHandler won't be registered and used.

I've rebased the change.

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable