vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Fix resize at runtime for board #55

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

This change is Reviewable

Artur- commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


addon/src/main/java/com/vaadin/board/client/BoardConnector.java, line 42 at r1 (raw file):

    public void onStateChanged(StateChangeEvent stateChangeEvent) {
        super.onStateChanged(stateChangeEvent);
        getLayoutManager().addElementResizeListener(getWidget().getElement(), e-> {

Nooooooooooo This would add a new listener every time some part of the state is changed. Do this in init() instead


Comments from Reviewable

alvarezguille commented 7 years ago

addon/src/main/java/com/vaadin/board/client/BoardWidget.java, line 24 at r1 (raw file):

public native void redraw(Element elem)/*-{
    elem.redraw();
}-*/;

can it be done without arguments with this?


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


addon/src/main/java/com/vaadin/board/client/BoardConnector.java, line 42 at r1 (raw file):

Previously, Artur- (Artur) wrote…
Nooooooooooo This would add a new listener every time some part of the state is changed. Do this in `init()` instead

Done.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 9 of 12 files at r1, 3 of 3 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable