search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Feature/dash 27 #56

Closed svenruppert closed 7 years ago

svenruppert commented 7 years ago

This change is Reviewable

rogozinds commented 7 years ago

Review status: 0 of 24 files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

addon/src/main/java/com/vaadin/board/Row.java, line 61 at r1 (raw file):

    for (Component component : components) {
        addComponent(component);
    }

we don't need it. Parent class will handle it

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/AbstractParallelTest.java, line 29 at r1 (raw file):

//@RunOnHub("tb3-hub.intra.itmill.com") @RunLocally(value = Browser.CHROME) Use RunOnHub

Comments from Reviewable

svenruppert commented 7 years ago

Review status: 0 of 45 files reviewed at latest revision, 2 unresolved discussions.

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/AbstractParallelTest.java, line 29 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
> //@RunOnHub("tb3-hub.intra.itmill.com") > @RunLocally(value = Browser.CHROME) Use RunOnHub

Done.

addon/src/main/java/com/vaadin/board/Row.java, line 61 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
> for (Component component : components) { > addComponent(component); > } we don't need it. Parent class will handle it

Done.

Comments from Reviewable

svenruppert commented 7 years ago

Reviewed 2 of 35 files at r2. Review status: 2 of 48 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 6 of 24 files at r1, 19 of 35 files at r2. Review status: 27 of 48 files reviewed at latest revision, 6 unresolved discussions.

addon/src/main/java/com/vaadin/board/Board.java, line 4 at r2 (raw file):

import java.util.Collection; That's the only change in this file. Remove it.

integration-tests/config/template_selenium-grids.properties, line 1 at r2 (raw file):

nogrid=locale-ip locale-grid=locale-ip

vaadin-grid=tb3-hub.intra.itmill.com

What is this file?

integration-tests/config/template_testbench.properties, line 4 at r2 (raw file):

#firefox.profile.path=path-to/webdriver/gecko/geckodriver
webdriver.chrome.driver=path-to/webdriver/chrome/chromedriver
phantomjs.binary.path=path-to/webdriver/phantomjs/phantomjs

What is this file?

integration-tests/src/main/java/com/vaadin/addon/board/testUI/Dash27BasicChartUI.java, line 26 at r2 (raw file):

//todo make it dynamic What does this comment mean? Who will do it and then?

Comments from Reviewable

svenruppert commented 7 years ago

Reviewed 14 of 24 files at r1, 31 of 35 files at r2, 4 of 4 files at r3. Review status: 47 of 48 files reviewed at latest revision, 6 unresolved discussions.

addon/src/main/java/com/vaadin/board/Board.java, line 4 at r2 (raw file):

Previously, rogozinds (rogozinds) wrote…
> import java.util.Collection; That's the only change in this file. Remove it.

Done.

Comments from Reviewable

svenruppert commented 7 years ago

Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.

Comments from Reviewable

svenruppert commented 7 years ago

Reviewed 8 of 18 files at r5. Review status: 43 of 48 files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.

Comments from Reviewable

svenruppert commented 7 years ago

Reviewed 10 of 18 files at r5. Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.

Comments from Reviewable