vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Fix tests, that they run. #60

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

Remove not nessesary suppliers, lambdas


This change is Reviewable

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

DiegoCardoso commented 7 years ago

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/AbstractParallelTest.java, line 41 at r2 (raw file):

    public void setup() throws Exception {
        super.setup();
        getDriver().manage().window().setSize(new Dimension(1024,768));

Missing import for Dimension class


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r3. Review status: 1 of 6 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 1 of 6 files reviewed at latest revision, 1 unresolved discussion.


integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/AbstractParallelTest.java, line 41 at r2 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…
Missing import for `Dimension` class

Done.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 3 of 6 files at r1, 1 of 1 files at r2. Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 6 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 6 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

rogozinds commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.


integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/AbstractParallelTest.java, line 41 at r2 (raw file):

Previously, rogozinds (rogozinds) wrote…
Done.

Done.


Comments from Reviewable