search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Create a jar containing all needed HTML+JS #62

Closed Artur- closed 7 years ago

Artur- commented 7 years ago

This change is Reviewable

rogozinds commented 7 years ago

Reviewed 2 of 7 files at r1. Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion.

precompiled/src/main/frontend/bower.json, line 18 at r1 (raw file):

    "webcomponentsjs": "v1.0.0-rc.11"
  }
}

This file is generated so should this file be removed (added to .gitignore)

Comments from Reviewable

Artur- commented 7 years ago

Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion.

precompiled/src/main/frontend/bower.json, line 18 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
This file is generated so should this file be removed (added to .gitignore)

The frontend plugin uses bower.json to detect if the files in the folder have been created, so if I remove it, the other files (which are slightly modified) will be overwritten

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion.

precompiled/src/main/frontend/bower.json, line 18 at r1 (raw file):

Previously, Artur- (Artur) wrote…
The frontend plugin uses `bower.json` to detect if the files in the folder have been created, so if I remove it, the other files (which are slightly modified) will be overwritten

Ok. Seems like we can remove frontend plugin and vaadin-frontend-maven-plugin from integration-test pom? Otherwise our test UI still uses it's own plugin but not the precompiled version. I've done that, and I get an exception SEVERE: Could not find UI board/HEARTBEAT/ java.lang.ClassNotFoundException: com.vaadin.addon.board.testUI.board/HEARTBEAT/ at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:264) at com.vaadin.addon.board.testUI.TestUIProvider.getUIClass(TestUIProvider.java:29)

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion.

precompiled/src/main/frontend/bower.json, line 18 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
Ok. Seems like we can remove frontend plugin and vaadin-frontend-maven-plugin from integration-test pom? Otherwise our test UI still uses it's own plugin but not the precompiled version. I've done that, and I get an exception SEVERE: Could not find UI board/HEARTBEAT/ java.lang.ClassNotFoundException: com.vaadin.addon.board.testUI.board/HEARTBEAT/ at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:264) at com.vaadin.addon.board.testUI.TestUIProvider.getUIClass(TestUIProvider.java:29)

after removing frontend plugin from integration-tests, I've also tried to build WAR, and run it on tomcat, it failed.

Comments from Reviewable

Artur- commented 7 years ago

Review status: 2 of 8 files reviewed at latest revision, 1 unresolved discussion.

precompiled/src/main/frontend/bower.json, line 18 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
after removing frontend plugin from integration-tests, I've also tried to build WAR, and run it on tomcat, it failed.

Done, also works on Tomcat

Comments from Reviewable

rogozinds commented 7 years ago
:lgtm:

Reviewed 5 of 7 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable