vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Add testbench-api for board, fixes DASH-104 #65

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

This change is Reviewable

alvarezguille commented 7 years ago

a discussion (no related file): should it be vaadin-board-testbench-api instead of board-testbench-api?


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, alvarezguille (Guille) wrote…
should it be `vaadin-board-testbench-api` instead of `board-testbench-api`?

It's according to current naming as, board is not called vaadin-board


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, rogozinds (rogozinds) wrote…
It's according to current naming as, board is not called vaadin-board

Fixed, as other patch by artur changes artifact names for board and integeration tests.


Comments from Reviewable

Artur- commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 41 at r1 (raw file):

     * @return TestBenchElement direct children from the row.
     */
    public List<WebElement> getDirectChildren(){

This is unnecessary as $$ or findElements will do the job


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 41 at r1 (raw file):

Previously, Artur- (Artur) wrote…
This is unnecessary as `$$` or `findElements` will do the job

Done.


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 41 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
Done.

Done.


Comments from Reviewable

Artur- commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions.


testbench-api/src/main/java/com/vaadin/board/elements/BoardElement.java, line 38 at r2 (raw file):

 */
@ServerClass("com.vaadin.board.Board")
public class BoardElement extends AbstractElement {

Should extend AbstractComponentElement


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 29 at r2 (raw file):

 */
@ServerClass("com.vaadin.board.Row")
public class RowElement extends AbstractElement {

Should extend AbstractComponentContainerElement


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 29 at r2 (raw file):

Previously, Artur- (Artur) wrote…
Should extend `AbstractComponentContainerElement`

Done.


Comments from Reviewable

Artur- commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, all discussions resolved.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 29 at r2 (raw file):

Previously, rogozinds (rogozinds) wrote…
Done.

Container still missing


Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


testbench-api/src/main/java/com/vaadin/board/elements/RowElement.java, line 29 at r2 (raw file):

Previously, Artur- (Artur) wrote…
`Container` still missing

Now it's there :), sorry


Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 8 of 12 files at r1, 2 of 3 files at r2, 2 of 3 files at r3. Review status: 12 of 13 files reviewed at latest revision, 2 unresolved discussions.


integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/InnerRowIT.java, line 31 at r3 (raw file):

    List<WebElement> innerRow = board.findElements(By.xpath("//vaadin-board/vaadin-board-row/vaadin-board-row"));
    List<WebElement> innerRowChildren = board.findElements(By.xpath("//vaadin-board/vaadin-board-row/vaadin-board-row/*"));

it could use element query, but we can change it later too


testbench-api/pom.xml, line 41 at r3 (raw file):

false

this might result in javadoc jar not deployed


Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 2 of 2 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable