vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Create Java versions of Board examples #68

Closed DiegoCardoso closed 7 years ago

DiegoCardoso commented 7 years ago

Examples for:


This change is Reviewable

rogozinds commented 7 years ago

Reviewed 34 of 35 files at r1. Review status: 34 of 35 files reviewed at latest revision, 2 unresolved discussions.


integration-tests/src/main/resources/com/vaadin/addon/board/examples/.DS_Store, line 0 at r1 (raw file): I guess, this is added by mistake?


integration-tests/src/main/resources/com/vaadin/addon/board/examples/image-collage/.DS_Store, line 0 at r1 (raw file): Remove this


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 35 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

DiegoCardoso commented 7 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.


integration-tests/src/main/resources/com/vaadin/addon/board/examples/.DS_Store, line at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
I guess, this is added by mistake?

Done.


integration-tests/src/main/resources/com/vaadin/addon/board/examples/image-collage/.DS_Store, line at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…
Remove this

Done.


Comments from Reviewable

rogozinds commented 7 years ago
:lgtm:

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable