vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Add Row constructor and fix javadocs #81

Closed alvarezguille closed 7 years ago

alvarezguille commented 7 years ago

Also added missing braces and minor javadoc improvements


This change is Reviewable

rogozinds commented 7 years ago

Reviewed 2 of 3 files at r3, 1 of 1 files at r4. Review status: all files reviewed at latest revision, 2 unresolved discussions.


addon/src/main/java/com/vaadin/board/Board.java, line 22 at r4 (raw file):

consists on Wrong preposition, either based on or consists of https://english.stackexchange.com/questions/61600/consist-in-vs-consist-of


addon/src/main/java/com/vaadin/board/Board.java, line 25 at r4 (raw file):

 * Each Row consists of four columns, and can contain up to four components
 * taking one column each, or fewer components with multiple columns each as
 * long as sum of columns stays less than or equal to 4

a dot at the end of the sentence


Comments from Reviewable

alvarezguille commented 7 years ago

Review status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions.


addon/src/main/java/com/vaadin/board/Board.java, line 22 at r4 (raw file):

Previously, rogozinds (rogozinds) wrote…
> consists on Wrong preposition, either based on or consists of https://english.stackexchange.com/questions/61600/consist-in-vs-consist-of

Done.


addon/src/main/java/com/vaadin/board/Board.java, line 25 at r4 (raw file):

Previously, rogozinds (rogozinds) wrote…
a dot at the end of the sentence

Done.


Comments from Reviewable

rogozinds commented 7 years ago

Reviewed 1 of 1 files at r5. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable