search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Fix Spreadsheet test UI #89

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

This change is Reviewable

alvarezguille commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

integration-tests/src/main/java/com/vaadin/addon/board/testUI/CompatSpreadsheetUI.java, line 29 at r1 (raw file):

sheet.setWidth("100%");
sheet.setHeightUndefined();

what's the reason for this change?

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

integration-tests/src/main/java/com/vaadin/addon/board/testUI/CompatSpreadsheetUI.java, line 29 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
> sheet.setWidth("100%"); > sheet.setHeightUndefined(); what's the reason for this change?

Done.

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable