search

vaadin / board

Framework 8 version of vaadin-board
Other
8 stars 10 forks source link

Fix layout test UIs #90

Closed rogozinds closed 7 years ago

rogozinds commented 7 years ago

This change is Reviewable

alvarezguille commented 7 years ago

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions.

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/CompatHorizontalLayoutUIIT.java, line 15 at r1 (raw file):

 *
 */
public class CompatHorizontalLayoutUIIT extends AbstractParallelTest {

is this class covered by LayoutsCompatabilityIT?

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/LayoutsCompatabilityIT.java, line 16 at r1 (raw file):

@RunLocally(Browser.CHROME)

remove this

Comments from Reviewable

rogozinds commented 7 years ago

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/CompatHorizontalLayoutUIIT.java, line 15 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
is this class covered by LayoutsCompatabilityIT?

Yes

integration-tests/src/test/java/com/vaadin/addon/board/testbenchtests/LayoutsCompatabilityIT.java, line 16 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
> @RunLocally(Browser.CHROME) remove this

Done.

Comments from Reviewable

alvarezguille commented 7 years ago

Reviewed 5 of 7 files at r1, 1 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable