search

vaadin / collaboration-engine

The simplest way to build real-time collaboration into web apps
https://vaadin.com/collaboration
Other
3 stars 1 forks source link

CE does not work with BigDecimalField. #3

Closed Peppe closed 3 years ago

Peppe commented 3 years ago

Describe the bug This is a report from the customer during a call. Needs verification.

To Reproduce Steps to reproduce the behavior:

  1. Have a form with BigDecimalField
  2. Use CollaborationBinder on the form.
  3. Access the form in the browser
  4. Notice errors in inspector

According to the customer, you get an error about some propery set or missing tag. The customer traced it back that Field-highlighters field/outline.js has a list of supported tags, and vaadin-big-decimal-field is not in the list, while for example vaadin-number-fieldis. Throwing an exception in either case is a little weird.

He said that the error went away as they white-listed collaboration engine packages within application.properties. It sounds a bit unrelated.

Expected behavior BigDecimalField should work with Collaboration Engine.

Versions

pekam commented 3 years ago

I tried to reproduce. Field highlight works, but it's not tightly around the input like it should: image

Peppe commented 3 years ago

Here's a short clip on it for more context. Outline is in the wrong place, but everything still works. No errors in console. gif

Peppe commented 3 years ago

The outline of the field has been fixed so that the caption is not part of it, and it will be included in the next release.